Skip to content

Update examples for node-oracledb 4.1 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2019
Merged

Update examples for node-oracledb 4.1 #84

merged 1 commit into from
Nov 26, 2019

Conversation

cjbj
Copy link
Contributor

@cjbj cjbj commented Nov 26, 2019

Node-oracledb 4.1 was just released. This PR syncs the examples with https://github.com/oracle/node-oracledb/tree/master/examples

anthony-tuininga
anthony-tuininga approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@anthony-tuininga anthony-tuininga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These examples are replicated directly from the node-oracledb repository where they have already been reviewed.

@cjbj cjbj merged commit c690fc5 into oracle-samples:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-tuininga anthony-tuininga anthony-tuininga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjbj @anthony-tuininga