-
-
Notifications
You must be signed in to change notification settings - Fork 71
#113: Add JS platform support #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hot! I like! ❤️ |
👀 |
Hi @Rosomack :) Is there a chance for this PR getting reviewed? |
Hi @maik-mursall , @mattmook and I had a look. Ultimately, we'd love to support JS, but the lack of
Thanks for taking the time to contribute! We'll keep you posted. |
Closing - we will be adding in JS support shortly... watch this space 😃 |
We've just merged #113 adding JS support. Expect a new release soon! |
Hi @Rosomack, That's really great to hear. :D If I have time soon, I'll look at how you guys implemented it and see if I can learn from it. :D |
Implementation of #113
runBlocking
in shared code and replaced it with sensible coroutine-alternativesrunBlocking
Breaking changes:
SimpleSyntaxExtensions.blockingIntent
is now asuspend
-functionintent
-functions to besuspend
as well, but this at least is the only one where it's necessary.Notes:
SimpleDslThreadingTest
need to be ignored by JS.withTimeout
andawaitCount
completely block and never release