Added container with ext state option #224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rosomack
commented
Jun 13, 2024
| public override val settings: RealSettings, | ||
| subscribedCounterOverride: SubscribedCounter? = null |
There was a problem hiding this comment.
I had to hoist these params to the RealSettings so that we could use the refcount extension on the ext state flow. I didn't want to expose the subscribedCounter on Container as it would just pollute the API surface.
This was painful, and I'm not entirely happy with the RealSettings class the way it's defined currently, but it was necessary.
mattmook
reviewed
May 24, 2025
| @@ -134,14 +145,11 @@ class CalculatorViewModel(savedStateHandle: SavedStateHandle) : ViewModel() { | |||
| } | |||
|
|
|||
| @Parcelize | |||
| private data class CalculatorStateImpl( | |||
| data class InternalCalculatorState( | |||
There was a problem hiding this comment.
This single line highlights one of the biggest downsides with ContainerHostWithExtState, suddenly your internal state types are all public.
i can't see any obvious way around this though
|
#294 supersedes this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pattern that we often see is that as a
ContainerHostgrows in complexity, a lot of the Container's state may exist only to track theContainerHost's state.Essentially as we're mixing internal and external (e.g. UI) state it becomes increasingly taxing to hoist the UI state out of the container's state.
This PR introduces an optional
ContainerHostWithExtStateandContainerWithExtStatethat introduce a simple mapping layer and exposeextStateFlowfor collection in the UI. We take the internal state and apply the mapper in order to turn it into an external state. All you need to do as the dev is to implement this mapper.