Skip to content

use self.payload[:self.payload_len] for getting python string #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2016
Merged

use self.payload[:self.payload_len] for getting python string #18

merged 1 commit into from
Oct 28, 2016

Conversation

WGH-
Copy link
Contributor

@WGH- WGH- commented Oct 27, 2016

This is more Cythonic way, documented here
http://cython.readthedocs.io/en/latest/src/tutorial/strings.html#passing-byte-strings

It compiles to

    __Pyx_PyBytes_FromStringAndSize(
        __pyx_v_self->payload + 0,
        __pyx_v_self->payload_len - 0)

Which is the Cython macro wrapper which handles both Python 2 and
Python3.

Fixes #17

@WGH-
use self.payload[:self.payload_len] for getting python string
949f894 
This is more Cythonic way, documented here
http://cython.readthedocs.io/en/latest/src/tutorial/strings.html#passing-byte-strings

It compiles to
    __Pyx_PyBytes_FromStringAndSize(
        __pyx_v_self->payload + 0,
        __pyx_v_self->payload_len - 0)

Which is the Cython macro wrapper which handles both Python 2 and
Python3.

Fixes oremanj#17
@mattfox mattfox merged commit adb2545 into oremanj:master Oct 28, 2016
@mattfox
Copy link
Collaborator

mattfox commented Oct 28, 2016

Thanks @WGH-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WGH- @mattfox