Remove unnecessary conversion of byte order for set_mark #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As nfq_set_verdict2 coverts byte order of "mark" (unlike nfq_set_verdict_mark), we have not to do it on our own. Otherwise, for example, Packet.set_mark(0x1234) results in 0x34120000 on little-endian machines.
|
Thank you no2a for the pull request. This is exactly what I referred to back in August in this comment I had an open issue about it, didn't notice your pull request. I hope it can be merged soon! :) |
|
Hi @no2a @jllorente thanks for contributing, my apologies for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As nfq_set_verdict2 coverts byte order of "mark" (unlike
nfq_set_verdict_mark), we have not to do it on our own.
Otherwise, for example, Packet.set_mark(0x1234) results in
0x34120000 on little-endian machines.