argparse is required to run the scripts
#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you download the project, run `python setup.py install`, and then try to run the `mon-get-instance-stats.py` script, you'll end up getting a `ImportError: No module named argparse`. Adding `argparse` to the `install_requires` will ensure that the module is properly installed.
|
Thanks! Sorry for the late merge - I were not notified by email about this PR. |
|
I think this was only necessary for Python 2.6 as this is actually broken for me in Python 2.7 on CentOS 7 now as it's hit issues other packages have hit: Gallopsled/pwntools#598 More info: https://pypi.python.org/pypi/argparse/1.4.0 and https://docs.python.org/2.7/library/argparse.html |
|
The question is -- do we still need Python 2.6 support in 2018 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you download the project, run
python setup.py install, and then try to run themon-get-instance-stats.pyscript, you'll end up getting aImportError: No module named argparse. Addingargparseto theinstall_requireswill ensure that the required module is installed.