Ssl changed certificate warning #1598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SSL certificate verification is ready to test @jesmrec :) |
| if (file.isFolder()) { | ||
| return file; | ||
| } else if (getStorageManager() != null) { | ||
| String parentPath = file.getRemotePath().substring(0, |
There was a problem hiding this comment.
OCFile now has a method getRemoteParentPath that may replace this block. Let's take advantage of it :)
|
Reviewed, just a couple of minor comments. |
|
Updated, thanks @davivel |
|
👍 ; please, rebase on master before merging. |
40b445d to
a0e442a
Compare
|
Rebased on master |
|
🍿 |
|
Extra ball for release 2.0.0 |
|
We can close related issues owncloud/QA#199 and #609 now |
|
@davivel but then you need to rebase release-2 to master again and at some point open a PR merging release-2 back to master 😀 Nice bonus to v2.0.0 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report about a change in the server certificate when I refresh the list of files so that I am aware of possible man-in-the-middle attacks
Related issues: