Break out qualifiers normalization subroutine as its own function #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modify PackageURL constructor to accept a string of qualifiers in addition to a dictionary of qualifiers Signed-off-by: Jono Yang <jyang@nexb.com>
pombredanne
requested changes
Oct 4, 2018
src/packageurl.py
Outdated
| """ | ||
| Return normalized purl components. | ||
| """ | ||
| if encode is True: |
There was a problem hiding this comment.
You might want to make this a function that's shared: something like
def get_quoter(encode=True):
"""Return quoting callable given an `encode` tri-boolean (True, False or None)"""
....
pombredanne
reviewed
Oct 4, 2018
src/packageurl.py
Outdated
|
|
||
| if namespace: | ||
| namespace = namespace.strip().strip('/') | ||
| if type and type in ('bitbucket', 'github', 'pypi'): |
There was a problem hiding this comment.
In hindsight, if type in... would be enough
|
You said:
I did not see such change or did I miss something? |
The change is in line 193, during the type check for |
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
63ca00e to
2a4ceec
Compare
|
LGTM! thanks++ |
|
And I pushed a new version at https://pypi.org/project/packageurl-python/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By breaking out this functionality into its own function from
normalize(), users can easily create a dictionary of qualifiers from a properly formatted string of qualifiers and vice versa.Also, the PackageURL constructor has been changed to accept a string of qualifiers in addition to a dictionary of qualifiers.
Signed-off-by: Jono Yang jyang@nexb.com