Fix qualifiers string vs. dict nature #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling PackageURL.to_dict(encode=True) will return a string instead of a mapping. Otherwise we now always use and return OrderedDict for qualifiers Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Before this, we were saving a dict() in the qualifiers field of PackageURLMixin resulting in damaged data (Django being smart enough would serialize the dict() to a string. That string would not be usable to recreate a qualifiers mapping afterwards. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
|
Thanks! merging |
scovetta
pushed a commit
to scovetta/packageurl-python
that referenced
this pull request
Sep 19, 2020
Signed-off-by: Michael Scovetta <michael.scovetta@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some issues when serializing a PackageURL object to native types with the
to_dict()method: thequalifierswere returned always as a regular, non-ordered mapping instead of a string.With this PR, the signature has been update to
to_dict(encode=False). Ifencodeis True, the qualifiers will be returned as a string and not a mapping.If
encodeis False the mapping returned qualifiers is always an OrderedDict and not a plain dict().The django_contrib model mixin has been updated accordingly.