Skip to content

Only convert test function names to byte strings on Python 2 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2018
Merged

Only convert test function names to byte strings on Python 2 #8

merged 1 commit into from
Feb 7, 2018

Conversation

haikoschol
Copy link
Contributor

While investigating #6, I noticed the tests failing on Python 3, since unicode is set to str and str.encode() produces bytes. However, <function>.__name__ must always be a string object in both Python versions.

Signed-off-by: Haiko Schol ext-haiko.schol@here.com

Only convert test function names to byte strings on Python 2
434b424 
Signed-off-by: Haiko Schol <ext-haiko.schol@here.com>
@pombredanne
Copy link
Member

Thanks!

@pombredanne pombredanne merged commit fcf24e2 into package-url:master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haikoschol @pombredanne