-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Copy on write using weakrefs (part 2) #12036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tweak so addition of new columnsdoesn't cause copying improved tests, removed copy option from merge
@shoyer @jreback Ballpark timeline on refactor? Like, >1.5 years? If so, I think I'll set this aside.Trying to modify the DataFrame constructor just opened a huge can of worms I think it'd take a long time to work through. Till the refactor, any interest in making |
I'd like to get it done in under a year; in combing through the codebase I've been making lists of things to do. It's a large effort but luckily we have a huge test suite to protect us and help keep the train on the rails. Will keep you posted |
@wesm Great. Then will def set aside. :) |
@nickeubank thanks for all the effort / commentary tests. I think these will be useful in the refactor. |
@jreback thanks for the guidance! If nothing else, I now know a lot more about how references work in Python! :) |
@nickeubank If you want to apply that knowledge for some internet karma, this came up yesterday ;) |
@TomAugspurger on it, thanks Tom. |
Is there an open issue for this? I found a bunch of issues related to this, but didn't see any open ones. |
there are refeneced issues |
See wesm/pandas2#10 |
Continuation of #11500