ENH: Return locale based month_name and weekday_name values (#12805, #12806) #18164

mroeschke · 2017-11-08T04:29:11Z

tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

I am not sure what locales are available on the CI machines, but the test will run all available locales.

jreback · 2017-11-08T11:00:55Z

need to add month_name to nat docstrings generation

jreback · 2017-11-08T11:03:27Z

doc/source/whatsnew/v0.21.1.txt

-
-
+- :attr:`Timestamp.month_name`, :attr:`DatetimeIndex.month_name`, and :attr:`Series.dt.month_name` are now available (:issue:`12805`)
+- ``month_name` and ``weekday_name`` attributes will now return locale aware values (:issue:`12806`)


move the 2nd point to bug fix; only mention weekday_name and use attr (as u did for month_name)

jreback · 2017-11-08T11:08:42Z

pandas/tests/indexes/datetimes/test_misc.py

-
+    # GH 12806
+    @pytest.mark.parametrize('time_locale', tm.get_locales())
+    def test_datetimeindex_accessors(self, time_locale):


can u split out the month_name and weekday_name to a separate test
skip if number of locales is 0

can then check that we don’t skip on build where we should have a locales defined

mroeschke · 2017-11-09T07:28:13Z

Added month_name as a property to NaT, moved whatsnew updates, and moved name accessor tests to their own function with a skip if no locales are available.

jreback · 2017-11-09T13:16:21Z

doc/source/whatsnew/v0.21.1.txt

@@ -22,7 +22,7 @@ Other Enhancements
 ^^^^^^^^^^^^^^^^^^

 - :meth:`Timestamp.timestamp` is now available in Python 2.7. (:issue:`17329`)
-
+- :attr:`Timestamp.month_name`, :attr:`DatetimeIndex.month_name`, and :attr:`Series.dt.month_name` are now available (:issue:`12805`)


actually move these to 0.22, we can't backport this as you are using some of the new timeseries stuff

codecov · 2017-11-10T03:32:52Z

Codecov Report

Merging #18164 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #18164      +/-   ##
==========================================
+ Coverage    91.4%    91.4%   +<.01%     
==========================================
  Files         163      163              
  Lines       50064    50069       +5     
==========================================
+ Hits        45759    45768       +9     
+ Misses       4305     4301       -4

Flag	Coverage Δ
#multiple	`89.21% <100%> (+0.02%)`	⬆️
#single	`40.39% <100%> (-0.04%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/indexes/datetimes.py	`95.48% <100%> (+0.1%)`	⬆️
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/frame.py	`97.8% <0%> (-0.1%)`	⬇️
pandas/io/formats/format.py	`96.01% <0%> (ø)`	⬆️
pandas/core/generic.py	`95.72% <0%> (ø)`	⬆️
pandas/core/config_init.py	`98.34% <0%> (ø)`	⬆️
pandas/core/groupby.py	`92.04% <0%> (+0.01%)`	⬆️
pandas/plotting/_converter.py	`65.2% <0%> (+1.81%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca737ac...6f39578. Read the comment docs.

codecov · 2017-11-10T03:32:52Z

Codecov Report

Merging #18164 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #18164      +/-   ##
==========================================
+ Coverage   91.69%   91.69%   +<.01%     
==========================================
  Files         150      150              
  Lines       49043    48997      -46     
==========================================
- Hits        44968    44929      -39     
+ Misses       4075     4068       -7

Flag	Coverage Δ
#multiple	`90.07% <100%> (ø)`	⬆️
#single	`41.94% <12.5%> (+0.12%)`	⬆️

Impacted Files	Coverage Δ
pandas/core/indexes/datetimes.py	`95.57% <100%> (-0.02%)`	⬇️
pandas/core/indexes/base.py	`96.45% <0%> (-0.22%)`	⬇️
pandas/core/internals.py	`95.53% <0%> (-0.01%)`	⬇️
pandas/io/formats/format.py	`96.25% <0%> (-0.01%)`	⬇️
pandas/core/generic.py	`95.88% <0%> (-0.01%)`	⬇️
pandas/core/config_init.py	`100% <0%> (ø)`	⬆️
pandas/core/indexes/range.py	`95.7% <0%> (ø)`	⬆️
pandas/core/groupby.py	`92.31% <0%> (+0.17%)`	⬆️
pandas/io/formats/style.py	`96.22% <0%> (+0.18%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f271eb...d97f43b. Read the comment docs.

jorisvandenbossche · 2017-11-10T09:37:58Z

doc/source/whatsnew/v0.22.0.txt

@@ -94,7 +94,7 @@ Bug Fixes
 Conversion
 ^^^^^^^^^^

-
+- Bug in :attr:`Timestamp.weekday_name` and :attr:`DatetimeIndex.weekday_name` not returning locale aware values (:issue:`12806`)


I don't think we should this as a bug, it is rather an API change as we deliberately returned non-locale dependent values.

(and to be honest, I am also not sure that I really like locale-dependent return values)

we could add an additonal accessor, e.g. weekday_name_for_locale? (hate adding things, but I agree that this might not be only desirable in some cases).

We could turn weekday_name and month_name into functions that can accept a locale argument and default it to 'en_US.UTF8'? I think that would be clean, but it would definitely be an API change.

hmm, that's an idea. we could could make new ones weekday_names() (and then just deprecate weekday_name

jorisvandenbossche · 2017-11-10T16:20:30Z

@mroeschke We could turn weekday_name and month_name into functions that can accept a locale argument and default it to 'en_US.UTF8'? I think that would be clean, but it would definitely be an API change.

@jreback hmm, that's an idea. we could could make new ones weekday_names() (and then just deprecate weekday_name

That's an option. Another option is to leave it as is but to clearly document in those attributes how to get your locale dependent names. Eg it would be nice that the following would work:

In [26]: import calendar

In [27]: dt = pd.date_range('2016-01-01', periods=10, freq='10D')

In [28]: dt.weekday
Out[28]: Int64Index([4, 0, 3, 6, 2, 5, 1, 4, 0, 3], dtype='int64')

In [29]: dt.weekday.map(calendar.day_name)
...
TypeError: '_localized_day' object is not callable

(the problem here is that calendar.day_name is some kind of mapping (it has __getitem__) but not really)

This works:

In [32]: pd.Series(dt.weekday).map({i: calendar.day_name[i] for i in range(7)})
Out[32]: 
0       Friday
1       Monday
2     Thursday
3       Sunday
4    Wednesday
5     Saturday
6      Tuesday
7       Friday
8       Monday
9     Thursday
dtype: object

(second issue is that Index.map apparently does not work with dict, while Series.map does)

But I think both issues could be solved to make this easier.

jorisvandenbossche · 2017-11-10T16:23:58Z

(On the other hand, such a pointer in the docstring is certainly less discoverable than a month_name method, I just in doubt this is worth it adding yet another method ..)

jorisvandenbossche · 2017-11-10T16:26:20Z

Index.map dict issue is reported here: #13517

mroeschke · 2017-11-10T18:20:04Z

I'll summarize the proposals and add an additional one:

Default to the user's system's locale (this PR)
Create a new function (would personally prefer .day_name(locale='en_US.UTF8') harmonizing with calendar.day_name)
Default to English locale and enhance the docs with a locale recipe
Utilize pandas.set_option and add something like mode.time_locale, defaulting to the English locale.

I think 4) would be a nice option to maintain the existing behavior and minimize altering existing methods. Otherwise I think I'd prefer 3) over 2) (I realize the Pandas API is already large).

What do you guys think @jreback @jorisvandenbossche?

jreback · 2017-11-10T19:02:05Z

so I actually like renaming weekday_name -> day_name regardless here for consistency.

is interesting

I wonder how common the need to look things up in different locales is, if its not that common (guess), then this makes sense

appeals as well (talking about the argument for the locale in the function call)

mroeschke · 2017-11-20T19:51:29Z

I decided to implement a day_name(time_locale=None) and month_name(time_locale=None) method that can accept a locale argument. Wanted to run the implementation by you guys.

Also, should I got ahead and also depreciate the .weekday_name attribute in this PR?

jreback · 2017-11-23T16:34:24Z

I decided to implement a day_name(time_locale=None) and month_name(time_locale=None) method that can accept a locale argument. Wanted to run the implementation by you guys.

that sounds good

Also, should I got ahead and also depreciate the .weekday_name attribute in this PR?

yes this is also ok

mroeschke · 2018-01-12T06:09:51Z

Sorry for being idle on this PR. Rebased, and added the day_name() and month_name() methods to Timestamp and DatetimeIndex

jreback

can you also deprecate weekday_name (in favor of day_name)

jreback · 2018-01-12T11:54:08Z

pandas/_libs/tslibs/fields.pyx


    count = len(dtindex)
    out = np.empty(count, dtype=object)

    if field == 'weekday_name':
+        _dayname = np.array(['Monday', 'Tuesday', 'Wednesday', 'Thursday',


move (and import from) ccalendar

jreback · 2018-01-12T11:54:53Z

pandas/_libs/tslibs/fields.pyx

+                                 'friday', 'saturday', 'sunday'],
+                                dtype=np.object_)
+        else:
+            with set_locale(time_locale, locale.LC_TIME):


this function (the locale conversion of the names) should be in ccalandar.pyx
just have a function which takes the locale (default None), so this is much simpler here

jreback · 2018-01-12T11:56:02Z

pandas/_libs/tslibs/nattype.pyx

@@ -320,7 +325,32 @@ class NaTType(_NaT):
    # nan methods
    weekday = _make_nan_func('weekday', datetime)
    isoweekday = _make_nan_func('isoweekday', datetime)
+    month_name = _make_nan_func('month_name',  # noqa:E128
+        """


make this a named parameter

jreback · 2018-01-12T11:56:27Z

pandas/_libs/tslibs/nattype.pyx

@@ -42,8 +42,13 @@ _nat_scalar_rules[Py_GE] = False
 def _make_nan_func(func_name, cls):


make doc an optional parameter doc

mroeschke · 2018-01-13T06:40:33Z

Created get_locale_names in ccalendar.pyx that provides localized day and month names, _make_missing_value_func to replace _make_nan_func and _make_nat_func, and added deprecation to weekday_name

Although, I am not sure how to add a deprecation warning to DatetimeIndex.weekday_name since the method is pre-generated with _field_accessor

jreback

need tests that catch the deprecation warning

jreback · 2018-01-13T12:48:12Z

pandas/_libs/tslibs/timestamps.pyx

    @property
    def weekday_name(self):
+        """
+        .. depreciated:: 0.23.0


jreback · 2018-01-13T12:50:43Z

pandas/tests/indexes/datetimes/test_misc.py

@@ -342,6 +327,37 @@ def test_datetimeindex_accessors(self):
        assert dates.weekofyear.tolist() == expected
        assert [d.weekofyear for d in dates] == expected

+    # GH 12806
+    @pytest.mark.skipif(not tm.get_locales(), reason='No available locales')
+    @pytest.mark.parametrize('time_locale', tm.get_locales())


this should still test for locale is None

jreback · 2018-01-13T12:51:17Z

pandas/core/indexes/datetimes.py

@@ -1686,7 +1688,7 @@ def freq(self, value):
    weekday_name = _field_accessor(
        'weekday_name',
        'weekday_name',
-        "The name of day in a week (ex: Friday)\n\n.. versionadded:: 0.18.1")
+        "The name of day in a week (ex: Friday)\n\n.. depreciated:: 0.23.0")


need to show a deprecation warning for this as well

nvm i see this below

jreback · 2018-01-13T12:51:38Z

doc/source/whatsnew/v0.23.0.txt

@@ -202,6 +202,8 @@ Other Enhancements
 - ``Resampler`` objects now have a functioning :attr:`~pandas.core.resample.Resampler.pipe` method.
  Previously, calls to ``pipe`` were diverted to  the ``mean`` method (:issue:`17905`).
 - :func:`~pandas.api.types.is_scalar` now returns ``True`` for ``DateOffset`` objects (:issue:`18943`).
+- :meth:`Timestamp.month_name`, :meth:`DatetimeIndex.month_name`, and :meth:`Series.dt.month_name` are now available (:issue:`12805`)
+- :meth:`Timestamp.day_name` and :meth:`DatetimeIndex.day_name` are now available to return day names with a specified locale (:issue:`12806`)


need an entry in Deprecated section

jreback · 2018-01-13T12:52:43Z

pandas/_libs/tslibs/ccalendar.pyx

@@ -13,6 +13,9 @@ cimport numpy as np
 from numpy cimport int64_t, int32_t
 np.import_array()

+import locale
+from pandas.util.testing import set_locale
+from strptime import LocaleTime


move these imports inside get_locale_names

jreback · 2018-01-13T12:54:56Z

pandas/_libs/tslibs/timestamps.pyx

+            days = dict(enumerate(ccalendar.DAYS_FULL))
+        else:
+            names = ccalendar.get_locale_names('f_weekday', time_locale)
+            days = dict(enumerate(names))


move the dict(enumerate after the if (eg do it once)

jreback · 2018-01-13T12:55:05Z

pandas/_libs/tslibs/timestamps.pyx

+            months = dict(enumerate(ccalendar.MONTHS_FULL))
+        else:
+            names = ccalendar.get_locale_names('f_month', time_locale)
+            months = dict(enumerate(names))


jreback · 2018-02-25T21:06:26Z

rebase on master

mroeschke · 2018-02-26T05:03:33Z

Rebased on master and addressed your comments @jreback. Looks like a travis build timed out.

jreback

can you update the test that hits Series.dt.day_name (you have to add the new methods and remove the old one), in the series tests

jreback · 2018-02-26T11:14:44Z

pandas/_libs/tslibs/ccalendar.pyx

@@ -199,3 +208,27 @@ cpdef int32_t get_day_of_year(int year, int month, int day) nogil:

    day_of_year = mo_off + day
    return day_of_year
+
+
+cpdef get_locale_names(object name_type, object time_locale=None):


only needs to be cdef unless called elsewhere

jreback · 2018-02-26T11:15:10Z

pandas/_libs/tslibs/ccalendar.pyx

+    from pandas.util.testing import set_locale
+
+    with set_locale(time_locale, locale.LC_TIME):
+        locale_names = getattr(LocaleTime(), name_type)


you can just return this directly, no need to have a variable locale_names

jreback · 2018-02-26T11:15:47Z

pandas/_libs/tslibs/fields.pyx

@@ -85,7 +85,8 @@ def build_field_sarray(ndarray[int64_t] dtindex):

 @cython.wraparound(False)
 @cython.boundscheck(False)
-def get_date_name_field(ndarray[int64_t] dtindex, object field):
+def get_date_name_field(ndarray[int64_t] dtindex, object field,
+                        object time_locale=None):


rename to locale

jreback · 2018-02-26T11:16:18Z

pandas/_libs/tslibs/fields.pyx

@@ -96,23 +97,37 @@ def get_date_name_field(ndarray[int64_t] dtindex, object field):
        pandas_datetimestruct dts
        int dow



instead of using _dayname, _monthname, use cdef names ndarray[object]

jreback · 2018-02-26T11:18:15Z

pandas/_libs/tslibs/nattype.pyx

+        month_name : string
+        """)
+    day_name = _make_nan_func('day_name', # noqa:E128
+        """


can you added versionadded 0.23 to these

jreback · 2018-02-26T11:20:25Z

pandas/tests/indexes/datetimes/test_misc.py

+                expected_months = calendar.month_name[1:]
+
+        # GH 11128
+        dti = DatetimeIndex(freq='D', start=datetime(1998, 1, 1),


can you add a NaT here

jreback · 2018-02-26T11:21:17Z

pandas/tests/indexes/datetimes/test_misc.py

+    @pytest.mark.skipif(not tm.get_locales(), reason='No available locales')
+    @pytest.mark.parametrize('time_locale', tm.get_locales() + [None])
+    def test_datetime_name_accessors(self, time_locale):
+        if time_locale is None:


add a comment what you are setting here

jreback · 2018-02-26T11:21:39Z

pandas/tests/indexes/datetimes/test_misc.py

+        for day, name, eng_name in zip(range(4, 11),
+                                       expected_days,
+                                       english_days):
+            # Test Monday -> Sunday


can you move this comment to near the GH issue number

jreback · 2018-02-26T11:21:46Z

pandas/tests/indexes/datetimes/test_misc.py

+
+        # GH 12805
+        dti = DatetimeIndex(freq='M', start='2012', end='2013')
+        # Test January -> December


same, move this up

add a NaT here

jreback · 2018-02-26T11:22:08Z

pandas/tests/scalar/timestamp/test_timestamp.py

        # GH 17354
-        assert data.weekday_name == expected
+        # Test .weekday_name, .day_name(), .month_name


test with NaT

mroeschke · 2018-02-27T02:27:17Z

I believe I addressed everything

Testing NaT
Moved/added comments to tests
Added tests for Series.dt.*name
Added versionadded notes
reused get_name_date_field in Timestamp
renamed time_locale to locale

jreback · 2018-02-27T02:30:08Z

pandas/_libs/tslibs/fields.pyx

    """
    Given a int64-based datetime index, return array of strings of date
    name based on requested field (e.g. weekday_name)
    """
    cdef:
        Py_ssize_t i, count = 0
-        ndarray[object] out
+        ndarray[object] out, name
        pandas_datetimestruct dts


should be names

jreback · 2018-02-27T02:31:33Z

pandas/_libs/tslibs/timestamps.pyx

+        """
+        warnings.warn("`weekday_name` is deprecated and will be removed in a "
+                      "future version. Use `day_name` instead",
+                      DeprecationWarning)


can u have this call day_name

mroeschke · 2018-03-01T06:51:03Z

Changed name to names, and used the day_name method for weekday_name. All green

jreback

very small comments, also needs a rebase. ping on green.

jreback · 2018-03-01T23:07:56Z

doc/source/api.rst

@@ -581,6 +581,8 @@ These can be accessed like ``Series.dt.<property>``.
   Series.dt.round
   Series.dt.floor
   Series.dt.ceil
+   Series.dt.month_name


if weekday_name is anywhere here can you remove

jreback · 2018-03-01T23:09:09Z

pandas/core/indexes/datetimes.py

@@ -262,6 +262,8 @@ class DatetimeIndex(DatelikeOps, TimelikeOps, DatetimeIndexOpsMixin,
    to_pydatetime
    to_series
    to_frame


if weekday_name is here can u remove

jreback · 2018-03-01T23:10:02Z

@jorisvandenbossche @TomAugspurger lgtm. if any final comments.

Fix localiztion of months Add series test and whatsnew notes Modify test and lint Add Timestamp rst Address comments Lint, move whatsnew, remove hardcoded Monday, check that get_locale is None create functions instead of attributes Fix white space Modify tests Lint Rebase and add depreciation message Deprecate weekday_name, create localizing function in ccalendar.pyx clean up imports Address user comments Try to address ci issues Rebase and adjust tests Move some imports to top of file, remove dup implimention of day_name in fields Fix failing test allow path to accept weekday_name as well address review address review missed files fix typo and call internal method Fix lint modify pytest param for appvoyer fix more appvoyer tests Remove weekday_name availability

mroeschke · 2018-03-02T16:12:38Z

Removed doc instances of weekday_name and all green (minus a Travis timeout)

jreback · 2018-03-04T20:15:43Z

thanks @mroeschke nice patch!

jreback · 2018-03-05T11:27:28Z

@mroeschke a number of deprecation warnings need catching.
also these should be FutureWarning and not DeprecationWarning. can you do a followup.

  /home/travis/build/pandas-dev/pandas/pandas/tests/indexes/datetimes/test_misc.py:274: DeprecationWarning: `weekday_name` is deprecated and will be removed in a future version. Use `day_name` instead
    assert ts.weekday_name == eng_name

jreback requested changes Nov 8, 2017

View reviewed changes

jreback added Compat pandas objects compatability with Numpy or Python functions Enhancement Datetime Datetime data dtype labels Nov 8, 2017

mroeschke force-pushed the add_localtime branch from ca6eb78 to 52a1464 Compare November 9, 2017 07:24

jreback requested changes Nov 9, 2017

View reviewed changes

mroeschke force-pushed the add_localtime branch from 52a1464 to 6f39578 Compare November 10, 2017 03:32

jorisvandenbossche reviewed Nov 10, 2017

View reviewed changes

mroeschke force-pushed the add_localtime branch from 6f39578 to c4837dc Compare November 11, 2017 20:15

mroeschke force-pushed the add_localtime branch from c4837dc to 18822e6 Compare November 20, 2017 19:43

mroeschke force-pushed the add_localtime branch from 18822e6 to 1162f9a Compare November 22, 2017 01:43

mroeschke mentioned this pull request Dec 12, 2017

centralize and de-privatize month/day name constants #18728

Merged

4 tasks

mroeschke force-pushed the add_localtime branch from 1162f9a to ab57006 Compare January 12, 2018 05:48

jreback requested changes Jan 12, 2018

View reviewed changes

mroeschke force-pushed the add_localtime branch from ab57006 to b0aeb3e Compare January 13, 2018 06:25

jreback requested changes Jan 13, 2018

View reviewed changes

mroeschke force-pushed the add_localtime branch from 62181e6 to 025ab67 Compare January 14, 2018 05:18

mroeschke force-pushed the add_localtime branch 2 times, most recently from 616665a to 565b5b6 Compare February 26, 2018 01:58

jsexauer mentioned this pull request Feb 26, 2018

DEPR: Clean up list of deprecations from prior versions #6581

Closed

1 task

jreback requested changes Feb 26, 2018

View reviewed changes

mroeschke force-pushed the add_localtime branch from 72f5b01 to a1cd27b Compare February 27, 2018 02:23

jreback requested changes Feb 27, 2018

View reviewed changes

mroeschke force-pushed the add_localtime branch 2 times, most recently from 006ac9e to dbbfbe7 Compare February 28, 2018 19:04

jreback added this to the 0.23.0 milestone Mar 1, 2018

jreback approved these changes Mar 1, 2018

View reviewed changes

mroeschke force-pushed the add_localtime branch from 56d1f01 to d97f43b Compare March 2, 2018 03:27

TomAugspurger approved these changes Mar 2, 2018

View reviewed changes

jreback merged commit 607910b into pandas-dev:master Mar 4, 2018

mroeschke deleted the add_localtime branch March 5, 2018 05:44

mroeschke mentioned this pull request Mar 6, 2018

month_name/day_name warnings followup #20010

Merged

1 task

jreback mentioned this pull request Mar 6, 2018

CLN: followons to refactor of series/test_indexing.py #20014

Closed

3 tasks

jbrockmendel mentioned this pull request Apr 29, 2018

PERF: Regressions since v0.21 #18532

Closed

mroeschke mentioned this pull request Nov 25, 2019

DEPR: Remove weekday_name #29831

Merged

5 tasks

jreback mentioned this pull request Nov 28, 2019

DEPR: deprecations log for removed issues #13777

Closed

nameloCmaS mentioned this pull request Jan 15, 2024

dt.weekday_name - attribute removed from Pandas v1.0.0 pydata/xarray#8610

Closed

5 tasks

		@@ -42,8 +42,13 @@ _nat_scalar_rules[Py_GE] = False
		def _make_nan_func(func_name, cls):

		@@ -96,23 +97,37 @@ def get_date_name_field(ndarray[int64_t] dtindex, object field):
		pandas_datetimestruct dts
		int dow

Uh oh!

ENH: Return locale based month_name and weekday_name values (#12805, #12806) #18164

ENH: Return locale based month_name and weekday_name values (#12805, #12806) #18164

Uh oh!

Conversation

mroeschke commented Nov 8, 2017 • edited by jreback Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jreback commented Nov 8, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mroeschke commented Nov 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 10, 2017

Codecov Report

Uh oh!

codecov bot commented Nov 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jorisvandenbossche commented Nov 10, 2017

Uh oh!

jorisvandenbossche commented Nov 10, 2017

Uh oh!

jorisvandenbossche commented Nov 10, 2017

Uh oh!

mroeschke commented Nov 10, 2017

Uh oh!

jreback commented Nov 10, 2017

Uh oh!

mroeschke commented Nov 20, 2017

Uh oh!

jreback commented Nov 23, 2017

Uh oh!

mroeschke commented Jan 12, 2018

Uh oh!

jreback left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mroeschke commented Jan 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jreback left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mroeschke commented Nov 8, 2017 •

edited by jreback

Loading

codecov bot commented Nov 10, 2017 •

edited

Loading

mroeschke commented Jan 13, 2018 •

edited

Loading