BUG: all-na corner case for str.cat #24045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @h-vetinari! Thanks for submitting the PR.
|
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #24045 +/- ##
===========================================
+ Coverage 42.46% 92.34% +49.88%
===========================================
Files 161 161
Lines 51557 51557
===========================================
+ Hits 21892 47612 +25720
+ Misses 29665 3945 -25720
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24045 +/- ##
=======================================
Coverage 42.45% 42.45%
=======================================
Files 161 161
Lines 51561 51561
=======================================
Hits 21888 21888
Misses 29673 29673
Continue to review full report at Codecov.
|
jreback
requested changes
Dec 2, 2018
doc/source/whatsnew/v0.24.0.rst
Outdated
| @@ -1364,6 +1364,7 @@ Strings | |||
| - Bug in :meth:`Index.str.partition` was not nan-safe (:issue:`23558`). | |||
| - Bug in :meth:`Index.str.split` was not nan-safe (:issue:`23677`). | |||
| - Bug :func:`Series.str.contains` not respecting the ``na`` argument for a ``Categorical`` dtype ``Series`` (:issue:`22158`) | |||
| - Bug in :meth:`Index.str.cat` when the result contained only NaN (:issue:`24044`) | |||
pandas/tests/test_strings.py
Outdated
|
|
||
| # all-NA target | ||
| expected = Index([np.nan] * 4, dtype='object') | ||
| expected = expected if box == Index else Series(expected, |
There was a problem hiding this comment.
use the
if box == Series:
.....
for this one
|
@jreback Ping on green. |
jreback
approved these changes
Dec 2, 2018
|
thanks @h-vetinari |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff