Skip to content

Misc separable pieces of #24024 #24488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 30, 2018
Merged

Misc separable pieces of #24024 #24488

merged 6 commits into from
Dec 30, 2018

Conversation

jbrockmendel
Copy link
Member

mostly shift

@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #24488 into master will decrease coverage by 49.23%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24488       +/-   ##
===========================================
- Coverage    92.3%   43.07%   -49.24%     
===========================================
  Files         166      166               
  Lines       52386    52371       -15     
===========================================
- Hits        48357    22557    -25800     
- Misses       4029    29814    +25785
Flag Coverage Δ
#multiple ?
#single 43.07% <25%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/datetimelike.py 45.73% <ø> (-49.75%) ⬇️
pandas/core/arrays/period.py 40.91% <ø> (-57.48%) ⬇️
pandas/core/indexes/base.py 56.49% <ø> (-39.8%) ⬇️
pandas/core/indexes/datetimelike.py 53.77% <0%> (-42.46%) ⬇️
pandas/core/groupby/groupby.py 24.5% <0%> (-72.3%) ⬇️
pandas/core/indexes/datetimes.py 48.8% <100%> (-47.53%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/core/categorical.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41b2b18...8816763. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 29, 2018 •
edited
Loading

Codecov Report

Merging #24488 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24488      +/-   ##
==========================================
+ Coverage    92.3%   92.31%   +<.01%     
==========================================
  Files         166      166              
  Lines       52386    52394       +8     
==========================================
+ Hits        48357    48366       +9     
+ Misses       4029     4028       -1
Flag Coverage Δ
#multiple 90.73% <100%> (ø) ⬆️
#single 43.05% <40%> (-0.02%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 98.39% <ø> (-0.01%) ⬇️
pandas/core/indexes/base.py 96.37% <ø> (+0.09%) ⬆️
pandas/core/arrays/datetimelike.py 95.47% <100%> (ø) ⬆️
pandas/core/indexes/datetimelike.py 96.22% <100%> (-0.02%) ⬇️
pandas/core/groupby/groupby.py 96.8% <100%> (ø) ⬆️
pandas/core/indexes/datetimes.py 96.31% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41b2b18...bfebc52. Read the comment docs.

@gfyoung gfyoung added Refactor Internal refactoring of code Internals Related to non-user accessible pandas implementation Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff labels Dec 30, 2018
@gfyoung gfyoung requested a review from jreback December 30, 2018 04:33
@jreback jreback added this to the 0.24.0 milestone Dec 30, 2018
@jreback jreback merged commit 460945e into pandas-dev:master Dec 30, 2018
@jreback
Copy link
Contributor

jreback commented Dec 30, 2018

thanks @jbrockmendel nice to see removing the deepcopy thingy and other cleanups; keep em coming.

@jbrockmendel jbrockmendel deleted the separate branch December 30, 2018 18:41
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
Misc separable pieces of pandas-dev#24024 (pandas-dev#24488)
190290e
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
Misc separable pieces of pandas-dev#24024 (pandas-dev#24488)
85663ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback Awaiting requested review from jreback

Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @gfyoung