Skip to content

Backport PR #25352: TST: xfail excel styler tests, xref GH25351 #25363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2019
Merged

Backport PR #25352: TST: xfail excel styler tests, xref GH25351 #25363

merged 1 commit into from
Feb 19, 2019

Conversation

jorisvandenbossche
Copy link
Member

Backports #25352, as the excel tests are also failing on 0.24.x (cc @jreback )

@jorisvandenbossche jorisvandenbossche added this to the 0.24.2 milestone Feb 18, 2019
@jreback
Copy link
Contributor

jreback commented Feb 18, 2019

must be an openpyxl or other excel library breakage

@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #25363 into 0.24.x will increase coverage by 49.51%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           0.24.x   #25363       +/-   ##
===========================================
+ Coverage   42.87%   92.39%   +49.51%     
===========================================
  Files         166      166               
  Lines       52410    52410               
===========================================
+ Hits        22472    48425    +25953     
+ Misses      29938     3985    -25953
Flag Coverage Δ
#multiple 90.82% <ø> (?)
#single 42.87% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/computation/pytables.py 92.35% <0%> (+0.3%) ⬆️
pandas/io/pytables.py 92.31% <0%> (+0.92%) ⬆️
pandas/util/_test_decorators.py 90.54% <0%> (+4.05%) ⬆️
pandas/compat/__init__.py 57.91% <0%> (+8.1%) ⬆️
pandas/core/config_init.py 99.24% <0%> (+9.84%) ⬆️
pandas/io/formats/console.py 66.66% <0%> (+10.14%) ⬆️
pandas/io/formats/terminal.py 32.53% <0%> (+10.84%) ⬆️
pandas/core/api.py 100% <0%> (+13.79%) ⬆️
pandas/compat/numpy/__init__.py 92.85% <0%> (+14.28%) ⬆️
pandas/core/computation/common.py 85.71% <0%> (+14.28%) ⬆️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07bb3ed...07c4c43. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 18, 2019 •
edited
Loading

Codecov Report

Merging #25363 into 0.24.x will increase coverage by 49.51%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           0.24.x   #25363       +/-   ##
===========================================
+ Coverage   42.87%   92.39%   +49.51%     
===========================================
  Files         166      166               
  Lines       52410    52410               
===========================================
+ Hits        22472    48425    +25953     
+ Misses      29938     3985    -25953
Flag Coverage Δ
#multiple 90.82% <ø> (?)
#single 42.87% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/computation/pytables.py 92.35% <0%> (+0.3%) ⬆️
pandas/io/pytables.py 92.31% <0%> (+0.92%) ⬆️
pandas/util/_test_decorators.py 90.54% <0%> (+4.05%) ⬆️
pandas/compat/__init__.py 57.91% <0%> (+8.1%) ⬆️
pandas/core/config_init.py 99.24% <0%> (+9.84%) ⬆️
pandas/io/formats/console.py 66.66% <0%> (+10.14%) ⬆️
pandas/io/formats/terminal.py 32.53% <0%> (+10.84%) ⬆️
pandas/core/api.py 100% <0%> (+13.79%) ⬆️
pandas/compat/numpy/__init__.py 92.85% <0%> (+14.28%) ⬆️
pandas/core/computation/common.py 85.71% <0%> (+14.28%) ⬆️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07bb3ed...07c4c43. Read the comment docs.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite IO Excel read_excel, to_excel labels Feb 18, 2019
@jorisvandenbossche jorisvandenbossche merged commit 82a4949 into pandas-dev:0.24.x Feb 19, 2019
@jorisvandenbossche jorisvandenbossche deleted the bp-excel branch February 19, 2019 08:44
@jorisvandenbossche
Copy link
Member Author

must be an openpyxl or other excel library breakage

Yep, you opened #25351 to track that I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jorisvandenbossche @jreback @gfyoung