TYPING : Series.name -> Optional[Hashable] #29164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
approved these changes
Oct 22, 2019
|
No problem with changing but what caused this issue exactly? Something we need to account for with pickle compat? |
WillAyd
reviewed
Oct 22, 2019
| @@ -926,7 +927,7 @@ def aggregate(self, func=None, *args, **kwargs): | |||
|
|
|||
| agg = aggregate | |||
|
|
|||
| def _iterate_slices(self) -> Iterable[Tuple[Hashable, Series]]: | |||
| def _iterate_slices(self) -> Iterable[Tuple[Optional[Hashable], Series]]: | |||
There was a problem hiding this comment.
note there is a similar definition for SeriesGroupBy - not sure if that needs to change as well
There was a problem hiding this comment.
maybe IndexLabel = Optional[Hashable] in _typing.py
no. with check_untyped_defs (i.e. checks body of _unpickle_series_compat)..
and then assigned to |
|
Thanks! |
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
* TYPING : Series.name -> Optional[Hashable]
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
* TYPING : Series.name -> Optional[Hashable]
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* TYPING : Series.name -> Optional[Hashable]
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* TYPING : Series.name -> Optional[Hashable]
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
* TYPING : Series.name -> Optional[Hashable]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #29062 (comment)
cc @WillAyd @TomAugspurger