Skip to content

DEPR: change pd.concat sort=None to sort=False #29786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2019
Merged

DEPR: change pd.concat sort=None to sort=False #29786

merged 2 commits into from
Nov 25, 2019

Conversation

jbrockmendel
Copy link
Member

No description provided.

@gfyoung gfyoung added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Deprecate Functionality to remove in pandas Clean labels Nov 22, 2019
TomAugspurger
TomAugspurger reviewed Nov 22, 2019
View reviewed changes
WillAyd
WillAyd approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pandas/tests/frame/test_join.py
ctx = tm.assert_produces_warning(None, check_stacklevel=False)

with ctx:
with tm.assert_produces_warning(None, check_stacklevel=False):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We fail on warnings now right (?). I think could probably get rid of this altogether

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we fail on warnings for all builds, or just the one?

@WillAyd WillAyd added this to the 1.0 milestone Nov 22, 2019
@jbrockmendel @TomAugspurger
Update pandas/core/reshape/concat.py
e906742 
Co-Authored-By: Tom Augspurger <TomAugspurger@users.noreply.github.com>
@jreback jreback merged commit d6c6f18 into pandas-dev:master Nov 25, 2019
@jreback
Copy link
Contributor

jreback commented Nov 25, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-concat branch November 25, 2019 23:40
@jreback jreback mentioned this pull request Nov 25, 2019
Closed
This was referenced Dec 12, 2019
Closed
Merged
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
DEPR: change pd.concat sort=None to sort=False (pandas-dev#29786)
2a17159
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
DEPR: change pd.concat sort=None to sort=False (pandas-dev#29786)
635af31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Clean Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jbrockmendel @jreback @WillAyd @TomAugspurger @gfyoung