REF: implement cumulative ops block-wise #29872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Nov 27, 2019
jreback
requested changes
Nov 27, 2019
6 tasks
jreback
requested changes
Dec 27, 2019
|
ok with moving this later, does this need a whatsnew note / additional tests as @TomAugspurger asks? |
So far i haven't been able to write tests that fail without this. Haven't given up. |
|
do @TomAugspurger original tests work on master? |
good point! no, but they work here. will update |
|
Hello @jbrockmendel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-12-27 20:23:03 UTC |
|
same unrelated-looking docbuild failure as #29847. im guessing this is going to be affecting all PRs about now, will take a look |
TomAugspurger
approved these changes
Dec 30, 2019
jreback
approved these changes
Dec 30, 2019
|
thanks, looking forward to the cleanups! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffcc @TomAugspurger