Skip to content

Call finalize in Series.__array_ufunc__ #36553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Call finalize in Series.__array_ufunc__ #36553

wants to merge 3 commits into from

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Sep 22, 2020 •
edited by jreback
Loading

xref #28283

@TomAugspurger TomAugspurger added the metadata _metadata, .attrs label Sep 22, 2020
@TomAugspurger TomAugspurger added this to the 1.2 milestone Sep 22, 2020
@jbrockmendel
Copy link
Member

makes sense, looks mypy complaints

jreback
jreback requested changes Sep 27, 2020
View reviewed changes
pandas/core/series.py Outdated
@@ -739,7 +739,11 @@ def construct_return(result):
# GH#27198
raise NotImplementedError
return result
return self._constructor(result, index=index, name=name, copy=False)
# TODO: When we support multiple values in __finalize__, this should
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i understand what you mean, but can you expand on this for readers

@jreback
Copy link
Contributor

jreback commented Oct 2, 2020

hmm can you merge master

@TomAugspurger
Copy link
Contributor Author

This is being subsumed by #36955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
metadata _metadata, .attrs
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@TomAugspurger @jbrockmendel @jreback