Skip to content

Conversation

jbrockmendel
Copy link
Member

Fixed some incorrect type annotations, de-duplicate some code paths.

Copy link
Contributor

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked at _typing.py. Introducing InterpolateOptions is something we should pull over to pandas-stubs . Created pandas-dev/pandas-stubs#732 for that

@jbrockmendel jbrockmendel requested a review from mroeschke as a code owner June 14, 2023 15:29
@mroeschke mroeschke added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate ExtensionArray Extending pandas with custom dtypes or arrays. labels Jun 14, 2023
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could use a whatsnew note in 2.1 that EA.interpolate was added

@jbrockmendel
Copy link
Member Author

Looks good. Could use a whatsnew note in 2.1 that EA.interpolate was added

updated+green

@mroeschke mroeschke added this to the 2.1 milestone Jun 28, 2023
@mroeschke mroeschke merged commit c96544e into pandas-dev:main Jun 28, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the enh-interp branch June 28, 2023 21:53
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
* ENH: EA.interpolate

* update code check

* update docstring to appease code check

* inplace->copy

* whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: .interpolate() with EA Dtypes
3 participants