CoW: Enable CoW by default and remove warning build #56633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
# Conflicts: # pandas/tests/copy_view/test_indexing.py
|
cc @mroeschke this should be green now and ready to merge hopefully. That allows us to move forward with the deprecations here |
mroeschke
reviewed
Jan 31, 2024
mroeschke
reviewed
Jan 31, 2024
| @@ -456,8 +454,7 @@ def add3(x, y, z): | |||
| ufunc(ser, ser, df) | |||
|
|
|||
|
|
|||
| # TODO(CoW) see https://github.com/pandas-dev/pandas/pull/51082 | |||
| @td.skip_copy_on_write_not_yet_implemented | |||
| @pytest.mark.xfail(reason="see https://github.com/pandas-dev/pandas/pull/51082") | |||
There was a problem hiding this comment.
Is there a way to still test this with cow?
mroeschke
approved these changes
Jan 31, 2024
|
Just a merge conflict post ArrayManager merge. Feel free to merge after that |
# Conflicts: # pandas/_config/__init__.py # pandas/conftest.py # pandas/tests/extension/conftest.py
50 tasks
3 tasks
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd prefer to go this way in enabling CoW. Having it on makes it easier to enforce the change step by step rather than doing it all at once.