Skip to content

floordiv fix for large values #56647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 28, 2023
Merged

floordiv fix for large values #56647

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0ffc550
floordiv fix for large values
Dec 27, 2023
2697b11
fix
Dec 27, 2023
bdb734e
exact test
Dec 27, 2023
bcdee56
fix
Dec 28, 2023
c2b3e99
fix test
Dec 28, 2023
6b557b8
test
Dec 28, 2023
e6c7930
min version fix
Dec 28, 2023
08d213d
minimal repro
Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
min version fix
  • Loading branch information
Rohan Jain committed Dec 28, 2023
commit e6c7930c5a7e2561c60a83a7c50c3b57b51a568e
5 changes: 4 additions & 1 deletion pandas/core/arrays/arrow/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,10 @@ def cast_for_truediv(
):
# https://github.com/apache/arrow/issues/35563
# Arrow does not allow safe casting large integral values to float64.
return arrow_array.cast(pa.float64(), safe=False)
# Intentionally not using arrow_array.cast because it could be a scalar
# value in reflected case, and safe=False only added to
# scalar cast in pyarrow 13.
return pc.cast(arrow_array, pa.float64(), safe=False)
return arrow_array

def floordiv_compat(
Expand Down