Skip to content

Bug cov nat #60898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 23, 2025
Merged

Bug cov nat #60898

merged 13 commits into from
May 23, 2025

Conversation

fbourgey
Copy link
Contributor

@fbourgey fbourgey commented Feb 9, 2025

WillAyd
WillAyd reviewed Feb 14, 2025
View reviewed changes
@WillAyd WillAyd added Datetime Datetime data dtype Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Feb 14, 2025
@fbourgey
Copy link
Contributor Author

@jbrockmendel, @WillAyd, could you please take a look?

WillAyd
WillAyd approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - @jbrockmendel anything else on your end?

@mroeschke mroeschke requested a review from jbrockmendel May 16, 2025 15:55
jbrockmendel
jbrockmendel reviewed May 17, 2025
View reviewed changes
jbrockmendel
jbrockmendel reviewed May 17, 2025
View reviewed changes
@fbourgey
Copy link
Contributor Author

@jbrockmendel, I made the updates

mroeschke
mroeschke reviewed May 21, 2025
View reviewed changes
pandas/core/frame.py Outdated
Comment on lines 11356 to 11357
dtypes = [blk.dtype for blk in self._mgr.blocks]
if any(d.kind in "mM" for d in dtypes):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dtypes = [blk.dtype for blk in self._mgr.blocks]
if any(d.kind in "mM" for d in dtypes):
if any(blk.dtype.kind in "mM" for blk in self._mgr.blocks):

mroeschke
mroeschke reviewed May 21, 2025
View reviewed changes
@mroeschke mroeschke added this to the 3.0 milestone May 22, 2025
mroeschke
mroeschke reviewed May 22, 2025
View reviewed changes
mroeschke
mroeschke reviewed May 22, 2025
View reviewed changes
pandas/tests/frame/methods/test_to_numpy.py Outdated
],
}
)
arr = np.array(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
arr = np.array(
expected = np.array(

mroeschke
mroeschke reviewed May 22, 2025
View reviewed changes
pandas/tests/frame/methods/test_to_numpy.py Outdated
[np.nan, 8.64e04, 2.00e00],
]
)
assert np.allclose(df.to_numpy(float, na_value=np.nan), arr, equal_nan=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert np.allclose(df.to_numpy(float, na_value=np.nan), arr, equal_nan=True)
result = df.to_numpy(float, na_value=np.nan),
tm.assert_numpy_array_equal(result, expected)

@mroeschke mroeschke merged commit cfe54bd into pandas-dev:main May 23, 2025
43 of 44 checks passed
@mroeschke
Copy link
Member

Thanks @fbourgey

@fbourgey fbourgey deleted the bug-cov-nat branch May 23, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@WillAyd WillAyd WillAyd approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Datetime Datetime data dtype Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

BUG: cov buggy when having NaT in column
4 participants
@fbourgey @mroeschke @WillAyd @jbrockmendel