-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUILD: Bump Cython to 3.1 #61519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUILD: Bump Cython to 3.1 #61519
Conversation
@@ -42,7 +42,7 @@ | |||
// followed by the pip installed packages). | |||
"matrix": { | |||
"pip+build": [], | |||
"Cython": ["3.0"], | |||
"Cython": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this was ever specified; we'll use our envornment.yaml for ASVs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also bump cython in the ci/deps
files?
I suppose after this PR we'll need to bump Cython in the conda forge recipe too
Bumped. The pin there was From the 2 to 3 transition, I was cautious about accepting new versions and I think now overly so. What do you think about |
Yeah I would be OK with that (modulo pinning below alpha/rc release versions since Cython often to pre-releases before major version bumps) |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Thanks @rhshadrach |
* Backport PR #61519: BUILD: Bump Cython to 3.1 * Remove files that don't exist on 2.3.x --------- Co-authored-by: Richard Shadrach <45562402+rhshadrach@users.noreply.github.com>
Why was the lower bound removed? I just tried building with cython 0.29.36 and the build failed. What is the correct lower bound? |
It seemed unnecessary, our CI will pull in 3.x regardless of the presence of a lower bound or not. I would imagine you'll need at least 3.0. If you have a use case for pandas guaranteeing support for older versions of Cython, can you open an issue. |
I definitely don't care about supporting older cython, I'm just worried that not specifying a lower bound will lead to issues. My specific issue occurred with the Spack package manager, not with pip. Not all package managers will always use a newer version if an old version is already installed. Conda may or may not have similar issues, I don't know enough about its internals. |
Thanks; I can update this to include |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.ASVs: #60972 (comment)