-
-
Notifications
You must be signed in to change notification settings - Fork 18.8k
DEPS: Bump Meson, lower pin Cython #62086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
pandas/_libs/tslibs/ccalendar.cp313-win_amd64.pyd.p/pandas/_libs/tslibs/ccalendar.pyx.c(9749): error C2220: the following warning is treated as an error |
Is it just me or is the meson system harder to debug than the old system? |
Yeah there's a little more indirection than before (meson-python -> meson vs just setuptools), but I understand the "standardization" of meson/cmake is better than the wild-west of using setuptools |
I don't have a strong point of view on bumping Meson, although I think it would be good to keep the lower bound as is until a new feature is required. (I definitely agree with un-pinning) If we do need the 1.6 bump, you will also want to add that change to the |
Since we recently adopted building with Cython 3 a while back, we don't want to allow users to build pandas with a Cython version lower than that