Skip to content

DEPS: Bump Meson, lower pin Cython #62086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mroeschke
Copy link
Member

Since we recently adopted building with Cython 3 a while back, we don't want to allow users to build pandas with a Cython version lower than that

@mroeschke mroeschke added Build Library building on various platforms Dependencies Required and optional dependencies labels Aug 10, 2025
@jbrockmendel
Copy link
Member

pandas/_libs/tslibs/ccalendar.cp313-win_amd64.pyd.p/pandas/_libs/tslibs/ccalendar.pyx.c(9749): error C2220: the following warning is treated as an error
pandas/_libs/tslibs/ccalendar.cp313-win_amd64.pyd.p/pandas/_libs/tslibs/ccalendar.pyx.c(9749): warning C4244: '=': conversion from 'Py_ssize_t' to 'long', possible loss of data

@jbrockmendel
Copy link
Member

Is it just me or is the meson system harder to debug than the old system?

@mroeschke
Copy link
Member Author

Is it just me or is the meson system harder to debug than the old system?

Yeah there's a little more indirection than before (meson-python -> meson vs just setuptools), but I understand the "standardization" of meson/cmake is better than the wild-west of using setuptools

@WillAyd
Copy link
Member

WillAyd commented Aug 11, 2025

I don't have a strong point of view on bumping Meson, although I think it would be good to keep the lower bound as is until a new feature is required. (I definitely agree with un-pinning)

If we do need the 1.6 bump, you will also want to add that change to the meson_version key in the project function call in meson.build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants