CLN: Enforce deprecation of DataFrame.idxmin/max with EAs and axis=1 #62201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
commented
Aug 26, 2025
Comment on lines
-5706
to
-5709
| raise ValueError( | ||
| f"{type(self).__name__}.{how} with skipna=False encountered an NA " | ||
| f"value." | ||
| ) |
There was a problem hiding this comment.
Changing the error message here to not identify the type of object that is raising the error. This should be apparent to the user already. If we include the type, then we'll need to catch and rethrow in the DataFrame case with axis=1 and EAs.
mroeschke
approved these changes
Aug 27, 2025
|
Thanks @rhshadrach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.#57971 enforced this deprecation in all cases except
axis=1with EAs as that used the groupby implementation which did not get deprecated at that time. We've since decided it is better to enforce this behavior change across the board (#62026), so we should also do theaxis=1with EA case.The whatsnew note:
still covers this, so no new note is needed.