Skip to content

Add Key Objects comparison #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Add Key Objects comparison #15

merged 2 commits into from
Apr 10, 2024

Conversation

tgonzalezorlandoarm
Copy link
Member

Implement:

  1. OSSL_FUNC_KEYMGMT_MATCH

for key objects as indicated by
https://www.openssl.org/docs/man3.0/man7/provider-keymgmt.html

This currently only checks whether selection is
'OSSL_KEYMGMT_SELECT_OTHER_PARAMETERS' and the key_name for both key objects match, as currently we don't support any other selection/data in Key Objects.

@tgonzalezorlandoarm tgonzalezorlandoarm self-assigned this Mar 11, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm force-pushed the tg/keymgmt-import branch 3 times, most recently from 09e1fd8 to 08184c3 Compare March 28, 2024 15:35
@tgonzalezorlandoarm tgonzalezorlandoarm changed the base branch from tg/keymgmt-import to main March 28, 2024 15:36
@tgonzalezorlandoarm tgonzalezorlandoarm force-pushed the tg/keymgmt-match branch 2 times, most recently from 73a680a to 62f6cc8 Compare April 5, 2024 15:47
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the tg/keymgmt-match branch April 5, 2024 19:03
@tgonzalezorlandoarm tgonzalezorlandoarm restored the tg/keymgmt-match branch April 5, 2024 19:03
@tgonzalezorlandoarm
Copy link
Member Author

Reopening PR. This has been closed accidentally as I've accidentally force pushed main in this PR without my changes. Hopefully this is restored now

Implement:

 1. OSSL_FUNC_KEYMGMT_MATCH

for key objects as indicated by
https://www.openssl.org/docs/man3.0/man7/provider-keymgmt.html

This currently only checks whether selection is
'OSSL_KEYMGMT_SELECT_OTHER_PARAMETERS' and the key_name for both
key objects match, as currently we don't support any other
selection/data in Key Objects.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
Copy link
Collaborator

@gowthamsk-arm gowthamsk-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gowthamsk-arm gowthamsk-arm merged commit ef7566f into main Apr 10, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the tg/keymgmt-match branch April 11, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants