Add test crate #17
Add test crate #17
Conversation
5454c12 to
c479ce1
Compare
d81ab70 to
8aeb5a6
Compare
|
A general comment for our entire CI testing setup, not for this PR in particular: |
We should also probably define it. I think it should be 1.66.0 like parsec |
|
|
||
| let provider_name = String::from("default"); | ||
|
|
||
| let mut lib_ctx: LibCtx = LibCtx::new().unwrap(); |
There was a problem hiding this comment.
I don't think this needs to be mut, right?
|
Thanks for the comments.:) |
|
Sure, thanks :) |
781ff79 to
d22a378
Compare
|
Seeing the CI failures, we should use https://docs.rs/env_logger/0.7.1/env_logger/fn.try_init.html instead of env_logger::init |
|
Could we please log errors in tests so that we can have more information? |
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
"evp.h" and "provider.h" APIs are needed for the test crate so generate them separately using the build.rs and include them in a test module. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
4005ff2 to
c57f462
Compare
| ), | ||
| 1 | ||
| ); | ||
| assert_ne!(parsec_pkey, std::ptr::null_mut()); |
There was a problem hiding this comment.
This is for the double pointer? Should it maybe be for the content of the pointer?
There was a problem hiding this comment.
Yes, that's right. I changed the function arguments to double pointer and forgot to update it here.
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Currently the tests are targeted towards the basic provider functions along with key management. Key loading is added for a dummy RSA key for the default provider. This needs to be changed after the key management feature is merged. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
c57f462 to
dcd55f6
Compare
Signed-off-by: Gowtham Suresh Kumar gowtham.sureshkumar@arm.com