Test building with MSRV #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tgonzalezorlandoarm
commented
Mar 20, 2024
- Separate build and test jobs in the CI
- Set the MSRV to 1.66.0 to be compatible with the current Parsec MSRV.
- Test building the provider with that MSRV.
This may be useful in the future to save CI resources in certain CI jobs that would only need to test whether the build is successful but don't need to perform run-time tests. Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
Set the MSRV to 1.66.0 to be compatible with the current Parsec MSRV. Test building the provider with MSRV. Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
Solve compilation issues when trying to compile with MSRV:
1) Use a version of env_logger that is compatible with MSRV.
2) The Error types declared by openssl_errors! were being marked as
private, which lead to the following error:
--> parsec-openssl-provider-shared/src/catch.rs:37:1
|
37 | / pub fn r#catch<T>(
38 | | function: Option<fn() -> openssl_errors::Function<super::Error>>,
39 | | f: impl FnOnce() -> Result<T, Box<dyn std::error::Error>>,
40 | | ) -> Result<T, ()> {
| |___________________^ can't leak private type
Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
From env_logger::init : This function will panic if it is called more than once, or if another library has already initialized a global logger. Use env_logger::try_init instead to make sure the code does not panic unnecessarily. Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
2fb36de to
12cc134
Compare
gowthamsk-arm
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.