Skip to content

Minor improvements #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Minor improvements #20

merged 3 commits into from
Mar 21, 2024

Conversation

gowthamsk-arm
Copy link
Collaborator

@gowthamsk-arm gowthamsk-arm commented Mar 21, 2024

The PR contains the following changes:

  1. Terminates key management algorithm table with NULL entry
  2. Terminates RSA key management dispatch table with NULL entry
  3. Ignore clippy lints related to multiple dependent versions

Signed-off-by: Gowtham Suresh Kumar gowtham.sureshkumar@arm.com

openssl expects the algorithm array to be terminated with a
NULL entry.

Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
@gowthamsk-arm gowthamsk-arm self-assigned this Mar 21, 2024
@gowthamsk-arm gowthamsk-arm added the bug Something isn't working label Mar 21, 2024
multiple-crate-versions lint in thrown for "cfg-if" and "syn" as
2 different versions of these crates are being used.
`cfg-if`: 0.1.10, 1.0.0
`syn`: 1.0.109, 2.0.52

Link to the lint:
https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions

These are coming from multiple dependencies and hence cannot be easily
resolved. This patch ignores these lints.

Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Dispatch tables have to be terminated with a NULL entry as openssl
expects it.

Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
@gowthamsk-arm gowthamsk-arm changed the title Add null algorithm to PARSEC_PROVIDER_KEYMGMT Minor improvements Mar 21, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm merged commit ebadf3e into main Mar 21, 2024
@gowthamsk-arm gowthamsk-arm deleted the gsk/minor_fix branch March 21, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants