Skip to content

signature: SIGNATURE library <-> provider functions #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2024
Merged

signature: SIGNATURE library <-> provider functions #23

merged 3 commits into from
Apr 12, 2024

Conversation

tgonzalezorlandoarm
Copy link
Member

@tgonzalezorlandoarm tgonzalezorlandoarm commented Mar 22, 2024 •
edited
Loading

Start implemententing the signature functions:

  • Implement OSSL_FUNC_signature_newctx, returning a dummy signature context. Right now, we are not using the properties parameter.
  • Implement OSSL_FUNC_signature_freectx, that frees the signature context.

Depends on #22

@tgonzalezorlandoarm tgonzalezorlandoarm self-assigned this Mar 22, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm changed the base branch from tg/more-signature to main March 22, 2024 13:41
@tgonzalezorlandoarm
Copy link
Member Author

Depends on #22

@tgonzalezorlandoarm tgonzalezorlandoarm mentioned this pull request Mar 22, 2024
Closed
@tgonzalezorlandoarm tgonzalezorlandoarm marked this pull request as draft March 22, 2024 13:45
@gowthamsk-arm gowthamsk-arm marked this pull request as ready for review March 25, 2024 09:59
gowthamsk-arm
gowthamsk-arm reviewed Mar 25, 2024
View reviewed changes
gowthamsk-arm
gowthamsk-arm reviewed Mar 25, 2024
View reviewed changes
gowthamsk-arm
gowthamsk-arm reviewed Mar 25, 2024
View reviewed changes
@tgonzalezorlandoarm tgonzalezorlandoarm force-pushed the tg/signature-new branch 2 times, most recently from fefea59 to d2801e8 Compare March 25, 2024 11:08
@tgonzalezorlandoarm tgonzalezorlandoarm marked this pull request as draft March 25, 2024 11:09
@tgonzalezorlandoarm tgonzalezorlandoarm force-pushed the tg/signature-new branch 3 times, most recently from e69e51f to c9b2916 Compare April 11, 2024 09:03
@tgonzalezorlandoarm tgonzalezorlandoarm marked this pull request as ready for review April 11, 2024 09:08
@tgonzalezorlandoarm tgonzalezorlandoarm force-pushed the tg/signature-new branch 3 times, most recently from b4786c2 to 0992ee7 Compare April 11, 2024 13:41
gowthamsk-arm
gowthamsk-arm reviewed Apr 11, 2024
View reviewed changes
gowthamsk-arm
gowthamsk-arm reviewed Apr 11, 2024
View reviewed changes
@tgonzalezorlandoarm tgonzalezorlandoarm mentioned this pull request Apr 11, 2024
Merged
@tgonzalezorlandoarm
signature: SIGNATURE library <-> provider functions
29269d7 
Start implemententing the signature functions:

 * Implement OSSL_FUNC_signature_newctx, returning a dummy signature
   context.
   Right now, we are not using the properties parameter.
 * Implement OSSL_FUNC_signature_freectx, that frees the signature
   context.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
@tgonzalezorlandoarm
signature: Add unit test for OSSL_FUNC_SIGNATURE_NEWCTX
3935563 
Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
@tgonzalezorlandoarm
e2e_tests: Ignore signing tests until signing is implemented
baa454e 
Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
gowthamsk-arm
gowthamsk-arm approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@gowthamsk-arm gowthamsk-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gowthamsk-arm gowthamsk-arm merged commit 8118788 into main Apr 12, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the tg/signature-new branch April 12, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gowthamsk-arm gowthamsk-arm gowthamsk-arm approved these changes

Assignees

@tgonzalezorlandoarm tgonzalezorlandoarm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgonzalezorlandoarm @gowthamsk-arm