Skip to content

load_key tests: Re-route to the parsec provider #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

tgonzalezorlandoarm
Copy link
Member

The load_key test is being routed to the default provider so as to test that the test itself is correct.
Now that this is confirmed:

  • Make the load_key test route the calls to the parsec provider instead. This will now verify that the key management functions are implemented correctly.
  • Remove todos
  • Modify the ci.sh script to print required logs when running tests.

The following changes will temporarily break the CI but are necessary to test the keymanagement implementation.

The load_key test is being routed to the default provider so as to
test that the test itself is correct.
Now that this is confirmed:

 * Make the load_key test route the calls to the parsec provider
   instead. This will now verify that the key management functions
   are implemented correctly.
 * Remove todos
 * Modify the ci.sh script to print required logs when running
   tests.

The following changes will temporarily break the CI but are
necessary to test the keymanagement implementation.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
@tgonzalezorlandoarm tgonzalezorlandoarm added the enhancement New feature or request label Mar 26, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm self-assigned this Mar 26, 2024
Copy link
Collaborator

@gowthamsk-arm gowthamsk-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gowthamsk-arm gowthamsk-arm merged commit 5ad53a3 into main Mar 28, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the tg/loadkey-tests-w-parsec branch March 28, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants