Skip to content

Add Parsec Basic Client #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 6, 2024
Merged

Add Parsec Basic Client #3

merged 3 commits into from
Mar 6, 2024

Conversation

tgonzalezorlandoarm
Copy link
Member

Make the Parsec Provider context have a reference to an instance of a Parsec Basic Client. This client will be used for any operation requests coming from the Parsec Provider.

@tgonzalezorlandoarm tgonzalezorlandoarm added the enhancement New feature or request label Feb 14, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm self-assigned this Feb 14, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm force-pushed the tg/keymanagement branch 4 times, most recently from 688c665 to e373470 Compare February 15, 2024 12:31
@gowthamsk-arm gowthamsk-arm force-pushed the null_provider branch 3 times, most recently from 40e4b1d to 39380ed Compare February 19, 2024 15:44
@tgonzalezorlandoarm tgonzalezorlandoarm changed the base branch from null_provider to main February 20, 2024 17:28
@tgonzalezorlandoarm
Copy link
Member Author

Please see results of: https://github.com/parallaxsecond/parsec-openssl-provider/actions/runs/8006758451

gowthamsk-arm
gowthamsk-arm reviewed Feb 22, 2024
View reviewed changes
@tgonzalezorlandoarm
Copy link
Member Author

New relevant run: https://github.com/parallaxsecond/parsec-openssl-provider/actions/runs/8017305100

@tgonzalezorlandoarm
Copy link
Member Author

New CI run : https://github.com/parallaxsecond/parsec-openssl-provider/actions/runs/8047902487

@tgonzalezorlandoarm
Copy link
Member Author

https://github.com/parallaxsecond/parsec-openssl-provider/actions/runs/8139096688

@gowthamsk-arm
Copy link
Collaborator

The order of CI execution looks a bit strange to me

+ openssl version
OpenSSL 3.0.2 15 Mar 2022 (Library: OpenSSL 3.0.2 15 Mar 2022)
+ pushd /tmp/parsec
/tmp/parsec /tmp/parsec-openssl-provider
+ popd
/tmp/parsec-openssl-provider
+ wait_for_service
++ pgrep parsec
+ ./target/debug/parsec -c e2e_tests/provider_cfg/mbed-crypto/config.toml
+ '[' -z 8 ']'
+ sleep 5
+ pgrep parsec

this ./target/debug/parsec -c e2e_tests/provider_cfg/mbed-crypto/config.toml runs after wait_for_service??

gowthamsk-arm
gowthamsk-arm reviewed Mar 4, 2024
View reviewed changes
@tgonzalezorlandoarm
Copy link
Member Author

The order of CI execution looks a bit strange to me

+ openssl version
OpenSSL 3.0.2 15 Mar 2022 (Library: OpenSSL 3.0.2 15 Mar 2022)
+ pushd /tmp/parsec
/tmp/parsec /tmp/parsec-openssl-provider
+ popd
/tmp/parsec-openssl-provider
+ wait_for_service
++ pgrep parsec
+ ./target/debug/parsec -c e2e_tests/provider_cfg/mbed-crypto/config.toml
+ '[' -z 8 ']'
+ sleep 5
+ pgrep parsec

this ./target/debug/parsec -c e2e_tests/provider_cfg/mbed-crypto/config.toml runs after wait_for_service??

I think this is due to CI's way of logging, in the ci.sh script it's definitely in the right order

@tgonzalezorlandoarm
Copy link
Member Author

https://github.com/parallaxsecond/parsec-openssl-provider/actions/runs/8144271957

gowthamsk-arm
gowthamsk-arm reviewed Mar 5, 2024
View reviewed changes
gowthamsk-arm
gowthamsk-arm reviewed Mar 5, 2024
View reviewed changes
@tgonzalezorlandoarm
Copy link
Member Author

https://github.com/parallaxsecond/parsec-openssl-provider/actions/runs/8173626578

gowthamsk-arm
gowthamsk-arm reviewed Mar 6, 2024
View reviewed changes
@tgonzalezorlandoarm
Add Parsec Basic Client to Parsec Provider Context
ca68f20 
Create a Parsec Provider context that contains a Parsec Basic Client.
This client will be used for any operation requests coming from the
Parsec Provider, so that it gets redirected to the Parsec Service.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
@tgonzalezorlandoarm
ci: Run the Parsec Service when testing
b97d752 
With the new addition of the Parsec Basic Client for the Parsec
Provider Context, we now need to run the Parsec Service in order
to create the client and use it for testing.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
@tgonzalezorlandoarm
Enable logging when provider is initialized
d83cc22 
Currently, errors are not displayed when they ocurr as there is no
actual logger that has been included.

 * Add env_logger as the logging unit.
 * Initialize the logging unit when the provider is initialized.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
@gowthamsk-arm gowthamsk-arm merged commit 83c2ecd into main Mar 6, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm mentioned this pull request Mar 6, 2024
Closed
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the tg/keymanagement branch March 28, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gowthamsk-arm gowthamsk-arm gowthamsk-arm approved these changes

@ionut-arm ionut-arm Awaiting requested review from ionut-arm

Assignees

@tgonzalezorlandoarm tgonzalezorlandoarm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgonzalezorlandoarm @gowthamsk-arm