Add signature tests for RSA and ECDSA #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgonzalezorlandoarm
requested changes
Apr 9, 2024
|
Could you please update the way we log the tests in here so that failures show their trace? |
gowthamsk-arm
commented
Apr 9, 2024
8cd2175 to
25354c1
Compare
|
I think this looks very good overall, just one minor comment |
The tests perform the signature operation via the Parsec OpenSSL Provider and verify the signature using the Parsec client with the name "parsec-tool". The keys should have been pre-generated before running the test using the parsec-tool. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
We will be adding an ECDSA key required for the test setup so the existing key name is changed to be specific. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
The openssl2 layer provides functions that map the error from openssl C calls to a rust error. This also provides proper logs for debugging in case of an error. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
d3d6c85 to
13e6166
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests perform the signature operation via the Parsec OpenSSL Provider and verify the signature using the Parsec client with the name "parsec-tool". The keys should have been pre-generated before running the test using the parsec-tool.
Signed-off-by: Gowtham Suresh Kumar gowtham.sureshkumar@arm.com