e2e_test: Add key type info to load_keys #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,7 +47,7 @@ fn test_loading_keys() { | |||
| let mut param = ossl_param!(PARSEC_PROVIDER_KEY_NAME, OSSL_PARAM_UTF8_PTR, my_key_name); | |||
| unsafe { | |||
| let mut parsec_pkey: *mut EVP_PKEY = std::ptr::null_mut(); | |||
| load_key(&lib_ctx, &mut param, &mut parsec_pkey); | |||
There was a problem hiding this comment.
Can we test loading both instead? (We should be freeing both as well)
The load_key function currently uses RSA key type by default which is a bug. This patch adds an argument to the function to enable using key type of choice. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
This patch moves the tests related to keys to a separate module. Also adds a test to load an ECDSA key from the parsec provider. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
1d99581 to
cf8ddd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The load_key function currently uses RSA key type by default which is a bug. This patch adds an argument to the function to enable using key type of choice.
Signed-off-by: Gowtham Suresh Kumar gowtham.sureshkumar@arm.com