Skip to content

signature: Enable ECDSA signing #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2024
Merged

signature: Enable ECDSA signing #44

merged 1 commit into from
Apr 16, 2024

Conversation

tgonzalezorlandoarm
Copy link
Member

  • Populate the ECDSA signing implementation table
  • Enable the ECDSA signing test that was previously being ignored
    • Minor logging improvement

@tgonzalezorlandoarm tgonzalezorlandoarm added the enhancement New feature or request label Apr 15, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm self-assigned this Apr 15, 2024
@tgonzalezorlandoarm
Copy link
Member Author

Depends on #39

@tgonzalezorlandoarm tgonzalezorlandoarm force-pushed the tg/signature-sign-ecdsa branch 3 times, most recently from 573f679 to 1d29cf7 Compare April 16, 2024 09:55
@tgonzalezorlandoarm
signature: Enable ECDSA signing
b2016c1 
 * Populate the ECDSA signing implementation table
 * Enable the ECDSA signing test that was previously being ignored
 * + Minor logging improvement

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
gowthamsk-arm
gowthamsk-arm approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@gowthamsk-arm gowthamsk-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@tgonzalezorlandoarm tgonzalezorlandoarm merged commit 2677975 into main Apr 16, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the tg/signature-sign-ecdsa branch April 16, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gowthamsk-arm gowthamsk-arm gowthamsk-arm approved these changes

Assignees

@tgonzalezorlandoarm tgonzalezorlandoarm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgonzalezorlandoarm @gowthamsk-arm