signature: Remove get_signature_len() function #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output of psa_sign_hash() gives a vector. We can extract the signature length from this function to handle the corner case when sig is NULL. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
|
I don't think this is applicable. The signature should not be calculated if this sig is NULL. |
|
I also don't think we should be trusting the contents of tbs when sig = NULL,as the user is expecting a signature length and not the signature to be calculated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of psa_sign_hash() gives a vector. We can extract the signature length from this function to handle the corner case when sig is NULL.
Signed-off-by: Gowtham Suresh Kumar gowtham.sureshkumar@arm.com