Add RSA-PSS support for handshake #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgonzalezorlandoarm
requested changes
May 15, 2024
| pub unsafe extern "C" fn parsec_provider_kmgmt_gettable_params( | ||
| _provctx: VOID_PTR, | ||
| ) -> *const OSSL_PARAM { | ||
| println!("In func parsec_provider_kmgmt_GETTABLE_params"); |
There was a problem hiding this comment.
Could you please remove this print?
There was a problem hiding this comment.
Dropped it now.
| .map_err(|_| "OSSL_PKEY_PARAM_RSA_E not found".to_string())?; | ||
|
|
||
| let mut exp = slice::from_raw_parts(exp_param.data as *const u8, exp_param.data_size).to_vec(); | ||
| //ToDo: endianess |
There was a problem hiding this comment.
ditto with the todo
There was a problem hiding this comment.
Will fix it.
| } | ||
| } else { | ||
| Ok(OPENSSL_SUCCESS) |
| PARSEC_PROVIDER_DESCRIPTION_ECDSA | ||
| ), | ||
| pub const PARSEC_PROVIDER_KEYMGMT: [OSSL_ALGORITHM; 2] = [ | ||
| // ossl_algorithm!( |
There was a problem hiding this comment.
Is it necessary to comment it out?
There was a problem hiding this comment.
Will drop this.
There was a problem hiding this comment.
Pushed a new commit as I had removed some const in another commit.
5930bf6 to
420b819
Compare
420b819 to
6345508
Compare
This patch adds a openssl support function which finds the desired param from the param array and sets it withe provided value. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
This is a temporary change. ECDSA support will be added in the follow-up PRs. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
The RSA component will store the modulus and exponent parts of the RSA public key in the Provider key object. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
The RSA key from x509 certificates will be loaded using the public params modulus and exponent. The import function now is capable of loading RSA public keys. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
The private key and public can only be compared using the public parts of the RSA key. Only if the match succeeds we can consider that a public key is related to the corresponding private key. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
We need digest_sign_init() as we need to calculate the digest and then sign the data. So drop sign_init() in this patch. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
cdedb0e to
32b4482
Compare
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
32b4482 to
e4eac5b
Compare
Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
Before, keymgmt match was testing for key names. This does not apply as what should be compared is the public key content in the TLS handshake. Remove that comparison and the corresponding tests. Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
f4500d6 to
8a3be2a
Compare
tgonzalezorlandoarm
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gowtham Suresh Kumar gowtham.sureshkumar@arm.com