Skip to content

e2e_tests/sign: Fix and simplify RSA and ECDSA signing tests #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2024
Merged

e2e_tests/sign: Fix and simplify RSA and ECDSA signing tests #62

merged 1 commit into from
May 20, 2024

Conversation

tgonzalezorlandoarm
Copy link
Member 

 * Adapt to the fact that ECDSA signature is split and serialized.
 * Calculate hash and use the pre-computed digest for signature verification

@tgonzalezorlandoarm tgonzalezorlandoarm added the bug Something isn't working label May 17, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm self-assigned this May 17, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm force-pushed the tg/fix-signing-tests branch 2 times, most recently from 094a030 to 287d6a1 Compare May 19, 2024 03:24
gowthamsk-arm
gowthamsk-arm reviewed May 20, 2024
View reviewed changes
@tgonzalezorlandoarm tgonzalezorlandoarm force-pushed the tg/fix-signing-tests branch 3 times, most recently from a61720d to 90377e0 Compare May 20, 2024 12:30
gowthamsk-arm
gowthamsk-arm previously approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@gowthamsk-arm gowthamsk-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tgonzalezorlandoarm tgonzalezorlandoarm force-pushed the tg/fix-signing-tests branch 4 times, most recently from 9bbb515 to 02da244 Compare May 20, 2024 15:15
@tgonzalezorlandoarm
e2e_tests/sign: Fix and simplify RSA and ECDSA signing tests
c6fdb46 
 * Adapt to the fact that ECDSA signature is split and serialized.
 * Calculate hash and use the pre-computed digest for signature
   verification

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
@tgonzalezorlandoarm tgonzalezorlandoarm merged commit 5bbcafe into main May 20, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the tg/fix-signing-tests branch May 20, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gowthamsk-arm gowthamsk-arm gowthamsk-arm left review comments

Assignees

@tgonzalezorlandoarm tgonzalezorlandoarm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgonzalezorlandoarm @gowthamsk-arm