Skip to content

Add license checks via cargo deny #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

tgonzalezorlandoarm
Copy link
Member

Check that all used dependencies are compatible with out current license.

The deny.toml is automatically generated by "cargo deny init" and then modify for our use case.

Check that all used dependencies are compatible with out current
license.

The deny.toml is automatically generated by "cargo deny init"

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
@tgonzalezorlandoarm
Copy link
Member Author

Nightly checks (where cargo deny happens): https://github.com/parallaxsecond/parsec-openssl-provider/actions/runs/9177256031

Copy link
Collaborator

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need the full template in deny.toml do we? Can we slimline it?

@tgonzalezorlandoarm
Copy link
Member Author

We do need the full template in deny.toml do we? Can we slimline it?

The deny.toml is auto-generated via "cargo deny init" command. By leaving it untouched (except for our required tuning), I'm leaving:

  1. The default values
  2. Comments with the options available should we need one in the future

I would leave it like this because of the reasons stated above, what do you think?

Copy link
Collaborator

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgonzalezorlandoarm tgonzalezorlandoarm merged commit 3d988e9 into main May 22, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the tg/add-cargo-deny branch May 22, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants