General improvements #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgonzalezorlandoarm
previously approved these changes
Mar 4, 2024
out and provctx are double pointers. Check if the first level of dereferencing is valid by testing for NULL pointers before assigning the values. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
The openssl.h header file would be hard to maintain while adding new features requiring new bindings. A more standard way of generating the bindings using pkg-config eases the process. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
52f3091 to
ec9fbd6
Compare
tgonzalezorlandoarm
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides following changes:
Signed-off-by: Gowtham Suresh Kumar gowtham.sureshkumar@arm.com