Skip to content

Fix the link checker job #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wiktor-k
Copy link
Collaborator

@wiktor-k wiktor-k commented Jul 29, 2025

The existing link checker didn't really work (it threw errors but they were not reported). Replace with something that actually works 😅

Signed-off-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
@wiktor-k
Copy link
Collaborator Author

Check if all check succeeded even though one of them didn't... why? 😢

@Jakuje
Copy link
Collaborator

Jakuje commented Jul 30, 2025

Check if all check succeeded even though one of them didn't... why? 😢

The check-matrix has dependency only on check matrix, but not on the tests-softhsmandtest-kryoptic` (nor on any other that we might want to depend on):

https://github.com/parallaxsecond/rust-cryptoki/actions/runs/16598679948/workflow?pr=302#L82

If we want this test to depend on any other intpus, they needs to be specified in needs dict.

@wiktor-k
Copy link
Collaborator Author

Thanks for the explanation! I think that by now these two are pretty stable... So... I propose we make them required too. Objections? CC @hug-dev

@Jakuje
Copy link
Collaborator

Jakuje commented Jul 30, 2025

Fine with me.

Note, that its nicely visualized in the pipeline summary with the dependency connection:

https://github.com/parallaxsecond/rust-cryptoki/actions/runs/16598679948?pr=302

I would not mind adding the other checks (spell, formatting, clippy, ...) as dependencies as we also want them to succeed. I do not remember what was required before though, but the point of changing from depending on several jobs was to have this configurable from within the git repo instead from the git webui (and avoid the need to require dozens of jobs to pass).

@hug-dev
Copy link
Member

hug-dev commented Aug 1, 2025

I would not mind adding the other checks (spell, formatting, clippy, ...) as dependencies as we also want them to succeed. I do not remember what was required before though, but the point of changing from depending on several jobs was to have this configurable from within the git repo instead from the git webui (and avoid the need to require dozens of jobs to pass).

Yes I like this reason! We can add them all there so that no admin is need on the UI :) The original reason was also to simplify admin and not manually add the matrix variants to the UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants