PG-1607 PG-1652 Unify argument order for KMIP and Vault providers #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument order differed between the CLI tool and the SQL functions which could cause confusion so we pick one order and standardize on it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (85.55%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #404 +/- ##
=====================================================
- Coverage 85.72% 85.55% -0.18%
=====================================================
Files 22 22
Lines 2529 2547 +18
Branches 387 388 +1
=====================================================
+ Hits 2168 2179 +11
- Misses 287 292 +5
- Partials 74 76 +2
🚀 New features to boost your workflow:
|
dAdAbird
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument order differed between the CLI tool and the SQL functions which could cause confusion so we pick one order and standardize on it.
I also decided to not make the CA cert parameter optional, passing NULL is good enough.