Skip to content

Remove some useless comments at top of files #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AndersAstrand
Copy link
Collaborator

@AndersAstrand AndersAstrand commented Jun 10, 2025

We're long past the years where someone is gonna read a print-out of these files and thus need a reminder of what the file name is. And even if someone wanted to do that it's easy to have your printer program automatically add the file name to the header or footer of each page now-a-days.

We weren't using these comments consistently anyways.

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.00%. Comparing base (3fc81cc) to head (3ba5ca6).

❌ Your project status has failed because the head coverage (85.00%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                Coverage Diff                 @@
##           TDE_REL_17_STABLE     #410   +/-   ##
==================================================
  Coverage              85.00%   85.00%           
==================================================
  Files                     21       21           
  Lines                   2560     2560           
  Branches                 392      392           
==================================================
  Hits                    2176     2176           
  Misses                   306      306           
  Partials                  78       78           
Components Coverage Δ
access 81.90% <ø> (ø)
catalog 88.82% <ø> (ø)
common 77.77% <ø> (ø)
encryption 73.45% <ø> (ø)
keyring 72.94% <ø> (ø)
src 91.44% <ø> (ø)
smgr 94.85% <ø> (ø)
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

We're long past the years where someone is gonna read a print-out of
these files and thus need a reminder of what the file name is. And even
if someone wanted to do that it's easy to have your printer program
automatically add the file name to the header or footer of each page
now-a-days.
@AndersAstrand AndersAstrand force-pushed the tde/remove-useless-comments-at-top-of-files branch from e8f99b6 to 3ba5ca6 Compare June 11, 2025 05:35
@AndersAstrand AndersAstrand merged commit ca790cd into percona:TDE_REL_17_STABLE Jun 11, 2025
16 checks passed
@AndersAstrand AndersAstrand deleted the tde/remove-useless-comments-at-top-of-files branch June 11, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants