Clean up some prefixes for function parameters #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no reason for name and type to be prefixed in the add/change key provider functions while options was not. The output from the list_providers functions had them for name and type, but not id nor options. So remove the prefixes there aswell. In other functions the prefixes serve to show what parameters is about the provider and which are about something else.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (84.92%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #418 +/- ##
=====================================================
- Coverage 84.92% 84.92% -0.01%
=====================================================
Files 21 21
Lines 2561 2560 -1
Branches 394 393 -1
=====================================================
- Hits 2175 2174 -1
Misses 306 306
Partials 80 80
🚀 New features to boost your workflow:
|
In the output from the key info functions the key_ prefix for the provider name and id columns doesn't add any value so let's harmonize them with how we name arguments to the key creation functions.
fcc9f25 to
324ac4c
Compare
jeltz
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some weirdness in there. provider id and provider options was not prefixed while name and type were always prefixed.
Also key info functions had double prefixes for provider attributes.