Skip to content

Add warning about WAL encryption being beta #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AndersAstrand
Copy link
Collaborator

It makes sense to warn about this when a key for WAL encryption is created as this is a necessary step before WAL encryption can be enabled.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base (f661cad) to head (bb29803).

❌ Your project status has failed because the head coverage (84.76%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                Coverage Diff                 @@
##           TDE_REL_17_STABLE     #426   +/-   ##
==================================================
  Coverage              84.75%   84.76%           
==================================================
  Files                     21       21           
  Lines                   2565     2566    +1     
  Branches                 393      393           
==================================================
+ Hits                    2174     2175    +1     
  Misses                   311      311           
  Partials                  80       80           
Components Coverage Δ
access 81.11% <ø> (ø)
catalog 88.62% <100.00%> (+0.01%) ⬆️
common 77.77% <ø> (ø)
encryption 73.45% <ø> (ø)
keyring 72.88% <ø> (ø)
src 91.44% <ø> (ø)
smgr 94.85% <ø> (ø)
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

It makes sense to warn about this when a key for WAL encryption is
created as this is a necessary step before WAL encryption can be
enabled.
@AndersAstrand AndersAstrand force-pushed the tde/add-warning-about-wal-beta branch from 906e1d3 to bb29803 Compare June 12, 2025 13:27
@AndersAstrand AndersAstrand merged commit 086b342 into percona:TDE_REL_17_STABLE Jun 12, 2025
16 checks passed
@AndersAstrand AndersAstrand deleted the tde/add-warning-about-wal-beta branch June 12, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants