Configure PDF generation plugin #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alina-derkach-oaza
commented
Jun 12, 2025
modified: contrib/pg_tde/documentation/_resource/overrides/partials/banner.html new file: contrib/pg_tde/documentation/_resourcepdf/overrides/404.html new file: contrib/pg_tde/documentation/_resourcepdf/overrides/main.html new file: contrib/pg_tde/documentation/_resourcepdf/overrides/partials/banner.html new file: contrib/pg_tde/documentation/_resourcepdf/overrides/partials/copyright.html new file: contrib/pg_tde/documentation/_resourcepdf/overrides/partials/header.html new file: contrib/pg_tde/documentation/docs/templates/pdf_cover_page.tpl deleted: contrib/pg_tde/documentation/mkdocs-pdf.yml modified: contrib/pg_tde/documentation/mkdocs.yml modified: contrib/pg_tde/documentation/requirements.txt
|
|
|
Here is the preview on Render |
Andriciuc
approved these changes
Jun 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (84.76%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #427 +/- ##
==================================================
Coverage 84.76% 84.76%
==================================================
Files 21 21
Lines 2567 2567
Branches 394 394
==================================================
Hits 2176 2176
Misses 311 311
Partials 80 80
🚀 New features to boost your workflow:
|
jeltz
reviewed
Jun 13, 2025
| <h1>404 - Not found</h1> | ||
| <p> | ||
| We can't find the page you are looking for. Try using the Search or <a href= "{{ config.extra.homepage | d(nav.homepage.url, true) | url }}"> return to homepage </a>. </p> | ||
| {% endblock %} |
There was a problem hiding this comment.
I see that several files miss a newline at the end. Is that something you could fix in whatever generates them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.