Update docs for change to set_key functions #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We removed the ability for the various set_key functions to actually create new keys and instead have a separate function for that as the API around "ensure_new_key" was confusing at best.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (84.65%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #433 +/- ##
==================================================
Coverage 84.65% 84.65%
==================================================
Files 21 21
Lines 2588 2588
Branches 401 401
==================================================
Hits 2191 2191
Misses 316 316
Partials 81 81
🚀 New features to boost your workflow:
|
Andriciuc
approved these changes
Jun 16, 2025
5610639
into
percona:TDE_REL_17_STABLE
23 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the ability for the various set_key functions to actually create new keys and instead have a separate function for that as the API around "ensure_new_key" was confusing at best.