Run postgresql TAP suite with WAL encryption enabled #535
Conversation
|
|
||
|
|
||
| sub _provider_config_file { | ||
| "\xff\xff\xff\xff\x67\x6c\x6f\x62\x61\x6c\x5f\x74\x65\x73\x74\x5f" . |
There was a problem hiding this comment.
Can't we generate "template" files in the setup suite, and then copy them for each test? That would be easier to understand/modify/verify than including a binary blob
There was a problem hiding this comment.
Yeah that would make sense. I just did the quickest thing I could think of for the PoC 🙂
3aac647 to
0e93481
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (82.22%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #535 +/- ##
==================================================
Coverage 82.22% 82.22%
==================================================
Files 25 25
Lines 3246 3246
Branches 512 512
==================================================
Hits 2669 2669
Misses 465 465
Partials 112 112
🚀 New features to boost your workflow:
|
aac976b to
615c60f
Compare
This release is supposed to be 2.0. The SQL upgrade file is a dummy, but I believe it's required.
This is the version we're about to release.
615c60f to
4ccb15e
Compare
b3b7e89 to
415cb8d
Compare
| if (defined($ENV{TDE_MODE})) | ||
| { | ||
| plan skip_all => "Slightly edited version of this test avaiable in pg_tde suite"; | ||
| } | ||
|
|
There was a problem hiding this comment.
The test in pg_tde suite do only sanity checks for the -E flag, hence it doesn't overlap with this test at all.
This is a concept for running the TAP suite with WAL encryption enabled when TDE_MODE=1.
I had to skip some tests (and also whole suites for tools we're not supporting in GA), but the rest passes.
TDE_MODE=1 meson test --no-suite pg_tde --no-suite pg_verifybackup --no-suite pg_combinebackup --no-suite pg_waldumppasses for me.There are still some test failures that might be because of test setup that I need to fix.
But do we like this? It's probably possible to monkeypatch
PostgreSQL::Test::Clusterby adding-MsomethingtoPROVE_FLAGS, but I'm not enough of a perl hacker to spend time on that right now.