PG-1867 Improve archiving test and fix race condition #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (82.40%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #545 +/- ##
==================================================
Coverage 82.40% 82.40%
==================================================
Files 25 25
Lines 3229 3229
Branches 510 510
==================================================
Hits 2661 2661
Misses 457 457
Partials 111 111
🚀 New features to boost your workflow:
|
5975865 to
ee33802
Compare
dAdAbird
approved these changes
Aug 19, 2025
contrib/pg_tde/t/wal_archiving.pl
Outdated
Comment on lines
145
to
150
| #$replica_plain->promote; | ||
| # | ||
| #$result = $replica_plain->safe_psql('postgres', | ||
| # 'SELECT * FROM t1 UNION ALL SELECT * FROM t2'); | ||
| # | ||
| #is($result, "foobar_plain\nfoobar_enc", 'b'); |
There was a problem hiding this comment.
Yes, it was only commented out temporarily while testing ...
There was a race condition in the WAL archiving tests where if the end-of-recovery checkpoint had completed the tests for the WAL contents were non-sensical and racy. Solve this by explicilty promoting the server first after we have looked at the WAL contents but still making sure to wait until all WAL has been replayed. Additionally improve the tests by actually making sure the replica starts in a good state where all WAL is encrypted and testing both the plaintext and the encrypted scenarios.
ee33802 to
42bee14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a race condition in the WAL archiving tests where if the end-of-recovery checkpoint had completed the tests for the WAL contents were non-sensical and racy. Solve this by explicilty promoting the server first after we have looked at the WAL contents but still making sure to wait until all WAL has been replayed.
Additionally improve the tests by actually making sure the replica starts in a good state where all WAL is encrypted and testing both the plaintext and the encrypted scenarios.